Skip to content

Fix failing test(s) in TimeSeriesDataStreamsIT #123378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nielsbauman merged 6 commits into from
Feb 26, 2025
Merged

Fix failing test(s) in TimeSeriesDataStreamsIT #123378

nielsbauman merged 6 commits into from
Feb 26, 2025

Conversation

@nielsbauman
Copy link
Contributor

@nielsbauman nielsbauman commented Feb 25, 2025

When these tests were run around midnight, the use of DataStream#getDefaultBackingIndexName could result in a potential mismatch in the generated index name and the one that the cluster actually created. Instead, we need to obtain the backing index and extract the desired index name from there.

Fixes #123086
Relates #123376

@nielsbauman
Fix failing test(s) in TimeSeriesDataStreamsIT
0ef2344 
When these tests were run around midnight, the use of
`DataStream#getDefaultBackingIndexName` could result in a potential
mismatch in the generated index name and the one that the cluster
actually created. Instead, we need to obtain the backing index and
extract the desired index name from there.

Fixes elastic#123086
Relates elastic#123376
@nielsbauman nielsbauman added >test Issues or PRs that are addressing/adding tests :Data Management/Data streams Data streams and their lifecycles Team:Data Management Meta label for data/management team auto-backport Automatically create backport pull requests when merged v8.18.1 v8.19.0 v9.0.1 v9.1.0 v8.16.5 v8.17.3 labels Feb 25, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Feb 25, 2025

Pinging @elastic/es-data-management (Team:Data Management)

samxbr
samxbr approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@samxbr samxbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nielsbauman
Don't use SetOnce
b338cbc 
On second thought, we can just get the backing index directly here as
well
@nielsbauman
Fix test
d294e37
@nielsbauman
Merge branch 'main' into fix-time-series-test
452ebe6
@nielsbauman
Fix test for real
b08157c
@nielsbauman nielsbauman merged commit f0f0eeb into elastic:main Feb 26, 2025
17 checks passed
@nielsbauman nielsbauman deleted the fix-time-series-test branch February 26, 2025 10:16
@nielsbauman nielsbauman mentioned this pull request Feb 26, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Feb 26, 2025

💔 Backport failed

Status Branch Result
❌ 8.18 Commit could not be cherrypicked due to conflicts
❌ 8.x Commit could not be cherrypicked due to conflicts
✅ 9.0
❌ 8.16 Commit could not be cherrypicked due to conflicts
❌ 8.17 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 123378

nielsbauman added a commit to nielsbauman/elasticsearch that referenced this pull request Feb 26, 2025
@nielsbauman
Fix failing test(s) in TimeSeriesDataStreamsIT (elastic#123378)
aa31831 
When these tests were run around midnight, the use of
`DataStream#getDefaultBackingIndexName` could result in a potential
mismatch in the generated index name and the one that the cluster
actually created. Instead, we need to obtain the backing index and
extract the desired index name from there.

Fixes elastic#123086
Relates elastic#123376
This was referenced Feb 26, 2025
Merged
Merged
nielsbauman added a commit to nielsbauman/elasticsearch that referenced this pull request Feb 26, 2025
@nielsbauman
Fix failing test(s) in TimeSeriesDataStreamsIT (elastic#123378)
ef41ba3 
When these tests were run around midnight, the use of
`DataStream#getDefaultBackingIndexName` could result in a potential
mismatch in the generated index name and the one that the cluster
actually created. Instead, we need to obtain the backing index and
extract the desired index name from there.

Fixes elastic#123086
Relates elastic#123376

(cherry picked from commit f0f0eeb)

# Conflicts:
#	x-pack/plugin/ilm/qa/multi-node/src/javaRestTest/java/org/elasticsearch/xpack/ilm/TimeSeriesDataStreamsIT.java
@nielsbauman nielsbauman mentioned this pull request Feb 26, 2025
Merged
nielsbauman added a commit to nielsbauman/elasticsearch that referenced this pull request Feb 26, 2025
@nielsbauman
Fix failing test(s) in TimeSeriesDataStreamsIT (elastic#123378)
41285d7 
When these tests were run around midnight, the use of
`DataStream#getDefaultBackingIndexName` could result in a potential
mismatch in the generated index name and the one that the cluster
actually created. Instead, we need to obtain the backing index and
extract the desired index name from there.

Fixes elastic#123086
Relates elastic#123376

(cherry picked from commit f0f0eeb)

# Conflicts:
#	x-pack/plugin/ilm/qa/multi-node/src/javaRestTest/java/org/elasticsearch/xpack/ilm/TimeSeriesDataStreamsIT.java
nielsbauman added a commit to nielsbauman/elasticsearch that referenced this pull request Feb 26, 2025
@nielsbauman
Fix failing test(s) in TimeSeriesDataStreamsIT (elastic#123378)
9b26e31 
When these tests were run around midnight, the use of
`DataStream#getDefaultBackingIndexName` could result in a potential
mismatch in the generated index name and the one that the cluster
actually created. Instead, we need to obtain the backing index and
extract the desired index name from there.

Fixes elastic#123086
Relates elastic#123376

(cherry picked from commit f0f0eeb)

# Conflicts:
#	x-pack/plugin/ilm/qa/multi-node/src/javaRestTest/java/org/elasticsearch/xpack/ilm/TimeSeriesDataStreamsIT.java
@nielsbauman nielsbauman mentioned this pull request Feb 26, 2025
Merged
@nielsbauman
Copy link
Contributor Author

nielsbauman commented Feb 26, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x
✅ 8.18
✅ 8.17
✅ 8.16

Questions ?

Please refer to the Backport tool documentation

nielsbauman added a commit to nielsbauman/elasticsearch that referenced this pull request Feb 26, 2025
@nielsbauman
Fix failing test(s) in TimeSeriesDataStreamsIT (elastic#123378)
7ef4d1c 
When these tests were run around midnight, the use of
`DataStream#getDefaultBackingIndexName` could result in a potential
mismatch in the generated index name and the one that the cluster
actually created. Instead, we need to obtain the backing index and
extract the desired index name from there.

Fixes elastic#123086
Relates elastic#123376

(cherry picked from commit f0f0eeb)

# Conflicts:
#	x-pack/plugin/ilm/qa/multi-node/src/javaRestTest/java/org/elasticsearch/xpack/ilm/TimeSeriesDataStreamsIT.java
elasticsearchmachine pushed a commit that referenced this pull request Feb 26, 2025
@nielsbauman
Fix failing test(s) in TimeSeriesDataStreamsIT (#123378) (#123471)
5a8a751 
When these tests were run around midnight, the use of
`DataStream#getDefaultBackingIndexName` could result in a potential
mismatch in the generated index name and the one that the cluster
actually created. Instead, we need to obtain the backing index and
extract the desired index name from there.

Fixes #123086
Relates #123376
nielsbauman added a commit that referenced this pull request Feb 26, 2025
@nielsbauman
[8.x] Fix failing test(s) in TimeSeriesDataStreamsIT (#123378) (#12…
294478a 
…3472)

When these tests were run around midnight, the use of
`DataStream#getDefaultBackingIndexName` could result in a potential
mismatch in the generated index name and the one that the cluster
actually created. Instead, we need to obtain the backing index and
extract the desired index name from there.

Fixes #123086
Relates #123376
elasticsearchmachine pushed a commit that referenced this pull request Feb 26, 2025
@nielsbauman
[8.16] Fix failing test(s) in TimeSeriesDataStreamsIT (#123378) (#1…
c8c16d0 
…23475)

* Fix failing test(s) in `TimeSeriesDataStreamsIT` (#123378)

When these tests were run around midnight, the use of
`DataStream#getDefaultBackingIndexName` could result in a potential
mismatch in the generated index name and the one that the cluster
actually created. Instead, we need to obtain the backing index and
extract the desired index name from there.

Fixes #123086
Relates #123376

(cherry picked from commit f0f0eeb)

# Conflicts:
#	x-pack/plugin/ilm/qa/multi-node/src/javaRestTest/java/org/elasticsearch/xpack/ilm/TimeSeriesDataStreamsIT.java

* Fix compilation
elasticsearchmachine pushed a commit that referenced this pull request Feb 26, 2025
@nielsbauman
[8.18] Fix failing test(s) in TimeSeriesDataStreamsIT (#123378) (#1…
6defed7 
…23473)

* Fix failing test(s) in `TimeSeriesDataStreamsIT` (#123378)

When these tests were run around midnight, the use of
`DataStream#getDefaultBackingIndexName` could result in a potential
mismatch in the generated index name and the one that the cluster
actually created. Instead, we need to obtain the backing index and
extract the desired index name from there.

Fixes #123086
Relates #123376

(cherry picked from commit f0f0eeb)

# Conflicts:
#	x-pack/plugin/ilm/qa/multi-node/src/javaRestTest/java/org/elasticsearch/xpack/ilm/TimeSeriesDataStreamsIT.java

* Fix compilation
nielsbauman added a commit that referenced this pull request Feb 27, 2025
@nielsbauman
[8.17] Fix failing test(s) in TimeSeriesDataStreamsIT (#123378) (#1…
2f8a6b8 
…23474)

When these tests were run around midnight, the use of
`DataStream#getDefaultBackingIndexName` could result in a potential
mismatch in the generated index name and the one that the cluster
actually created. Instead, we need to obtain the backing index and
extract the desired index name from there.

Fixes #123086
Relates #123376
@nielsbauman nielsbauman mentioned this pull request Mar 4, 2025
Closed
nielsbauman added a commit to nielsbauman/elasticsearch that referenced this pull request Mar 4, 2025
@nielsbauman
Unmute TimeSeriesDataStreamsIT.testSearchableSnapshotAction
107a448 
Already fixed by elastic#123378.

Closes elastic#123214
@nielsbauman nielsbauman mentioned this pull request Mar 4, 2025
Merged
elasticsearchmachine pushed a commit that referenced this pull request Mar 4, 2025
@nielsbauman
Unmute TimeSeriesDataStreamsIT.testSearchableSnapshotAction (#123973)
8c6df1f 
Already fixed by #123378.

Closes #123214
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Mar 11, 2025
@nielsbauman @georgewallace
Unmute TimeSeriesDataStreamsIT.testSearchableSnapshotAction (elasti…
82b7a66 
…c#123973)

Already fixed by elastic#123378.

Closes elastic#123214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samxbr samxbr samxbr approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged :Data Management/Data streams Data streams and their lifecycles Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v8.16.5 v8.17.3 v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] TimeSeriesDataStreamsIT class failing

3 participants

@nielsbauman @elasticsearchmachine @samxbr